liuxiran commented on a change in pull request #395:
URL: https://github.com/apache/apisix-dashboard/pull/395#discussion_r476103421
##########
File path: src/pages/SSL/locales/en-US.ts
##########
@@ -15,39 +15,41 @@
* limitations under the License.
*/
export default {
- 'ssl.form.expiration.time':'Expiration Time',
- 'ssl.form.public.key':'Public Key',
+ 'ssl.form.expiration.time': 'Expiration Time',
+ 'ssl.form.cert': 'Cert',
Review comment:
if `cert` is not very good, how about ` SSL Certificate` in English and
`证书`in Chinese? `public key` is ambiguous, It is easy to understand as an
encrypted public and private key， and it could not match the form item as well
I campared with aliyun apigateway, which is also use `证书`
maybe it is worth considering again😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
