hadican commented on code in PR #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372#discussion_r996806146
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -276,12 +276,21 @@ data:
role: viewer
etcd:
{{- if .Values.etcd.enabled }}
+ {{- if .Values.etcd.auth.tls.enabled }}
+ host: # it's possible to define
multiple etcd hosts addresses of the same etcd cluster.
+ {{- if .Values.etcd.fullnameOverride }}
+ - "https://{{ .Values.etcd.fullnameOverride }}:{{
.Values.etcd.service.port }}"
Review Comment:
How about a helper like:
```
{{/*
Scheme to use while connecting etcd
*/}}
{{- define "apisix.etcd.auth.scheme" -}}
{{- if .Values.etcd.auth.tls.enabled }}
{{- "https" }}
{{- else }}
{{- "http" }}
{{- end }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
