spacewander commented on code in PR #8119:
URL: https://github.com/apache/apisix/pull/8119#discussion_r1001498697


##########
apisix/plugins/ai.lua:
##########
@@ -132,6 +132,12 @@ local function routes_analyze(routes)
         core.log.info("use ai plane to match route")
         router.router_http.match = ai_match
 
+        local count = #routes + 3000

Review Comment:
   I am not familiar with the route cache design, so the questions below need 
to be answered by someone who is familiar with it. CC @membphis @tzssangglass 
   
   1. do we need to clean the cache when we switch 'cache' to 'no cache'?
   2. is it desirable to recreate cache once the router is rebuilt (a new route 
is added)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to