tzssangglass commented on code in PR #8130:
URL: https://github.com/apache/apisix/pull/8130#discussion_r1001537715


##########
apisix/plugins/ai.lua:
##########
@@ -138,6 +233,27 @@ local function routes_analyze(routes)
             router.router_http.match = orig_router_match
         end
     end
+
+    if not route_flags["service"]
+            and not route_flags["service_id"]
+            and not route_flags["upstream_id"]
+            and not route_flags["enable_websocket"]
+            and not route_flags["plugins"]
+            and not route_up_flags["has_domain"]
+            and route_up_flags["pass_host"]
+            and route_up_flags["scheme"]
+            and not route_up_flags["checks"]
+            and not route_up_flags["retries"]
+            and not route_up_flags["timeout"]
+            and not route_up_flags["timeout"]

Review Comment:
   fixed



##########
apisix/plugins/ai.lua:
##########
@@ -138,6 +233,27 @@ local function routes_analyze(routes)
             router.router_http.match = orig_router_match
         end
     end
+
+    if not route_flags["service"]
+            and not route_flags["service_id"]
+            and not route_flags["upstream_id"]
+            and not route_flags["enable_websocket"]
+            and not route_flags["plugins"]
+            and not route_up_flags["has_domain"]
+            and route_up_flags["pass_host"]
+            and route_up_flags["scheme"]
+            and not route_up_flags["checks"]
+            and not route_up_flags["retries"]
+            and not route_up_flags["timeout"]
+            and not route_up_flags["timeout"]
+            and not route_up_flags["keepalive"] then

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to