nic-chen commented on a change in pull request #2097:
URL: https://github.com/apache/apisix/pull/2097#discussion_r476885895



##########
File path: apisix/init.lua
##########
@@ -72,6 +72,12 @@ function _M.http_init(args)
     math.randomseed(seed)
     parse_args(args)
     core.id.init()
+

Review comment:
       In a container environment, users need to configure `logrotate` and 
`crontab`, and `alpine` image needs to install `logrotate` separately, which 
feels a bit complicated. 
   I think it's ok to provide an optional plugin.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to