[GitHub] [apisix] spacewander commented on a diff in pull request #8099: fix(zipkin): send trace IDs with a reject sampling decision

[GitBox]

spacewander commented on code in PR #8099:
URL: https://github.com/apache/apisix/pull/8099#discussion_r1005268568


##########
t/plugin/zipkin2.t:
##########
@@ -136,6 +137,7 @@ x-b3-spanid: e457b5a2e4d86bd1
 b3: 0
 --- response_headers
 x-b3-sampled: 0
+--- raw_response_headers_unlike

Review Comment:
   Let's use `raw_response_headers_like` too



##########
t/plugin/zipkin2.t:
##########
@@ -126,8 +126,9 @@ b3: 
80f198ee56343ba864fe8b2a57d3eff7-e457b5a2e4d86bd1-0-05e3ac9a4f6e3b90
 --- response_headers
 x-b3-sampled: 0
 x-b3-traceid: 80f198ee56343ba864fe8b2a57d3eff7
-x-b3-parentspanid: 05e3ac9a4f6e3b90
-x-b3-spanid: e457b5a2e4d86bd1
+x-b3-parentspanid: e457b5a2e4d86bd1
+--- raw_response_headers_like:

Review Comment:
   It should be:
   ```
   --- raw_response_headers_like
   .*x-b3-spanid:.*
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org