spacewander commented on code in PR #8180:
URL: https://github.com/apache/apisix/pull/8180#discussion_r1007688980
##########
t/admin/upstream.t:
##########
@@ -727,3 +727,31 @@ GET /t
{"error_msg":"failed to fetch ssl info by ssl id [1], wrong ssl type"}
--- no_error_log
[error]
+
+
+
+=== TEST 22: type with default vale
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/upstreams',
+ ngx.HTTP_PUT,
+ [[{
+ "id": 1,
+ "nodes": {
+ "127.0.0.1:8080": 1
+ }
+ }]]
Review Comment:
Better to check the default value of `type` like
https://github.com/apache/apisix/blob/48b84311067ae1b863cfcda23d079a262ff4a8ee/t/admin/upstream.t#L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
