checkin247 commented on issue #1421: URL: https://github.com/apache/apisix-ingress-controller/issues/1421#issuecomment-1298248209
@tao12345666333 I made the required modifications, you can check the difference here: https://github.com/apache/apisix-ingress-controller/compare/master...checkin247:apisix-ingress-controller:issue-1421 The mdlint is ok. TBD: 1) Should the manifests for "apiVersion: networking.k8s.io/v1beta1" also be updated? Example: docs/en/latest/tutorials/proxy-the-httpbin-service-with-ingress.md:83 (I guess not) 2) There are E2E tests which make use of the annotation, example: test/e2e/suite-ingress/suite-ingress-resource/ingress.go:738 test/e2e/suite-annotations/authorization.go:45 I assume modifying tests should be done by someone else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
