moonming commented on a change in pull request #2092:
URL: https://github.com/apache/apisix/pull/2092#discussion_r477824853
##########
File path: .travis/apisix_cli_test.sh
##########
@@ -23,7 +23,14 @@
set -ex
-git checkout conf/config.yaml
+cat > conf/config.yaml <<EOF
+apisix:
+ admin_key:
+ -
+ name: admin
+ key: ADMIN_API_KEY
Review comment:
We should use a more `real` key in the test case
##########
File path: .travis/apisix_cli_test.sh
##########
@@ -166,7 +200,14 @@ echo "passed: admin https enabled"
# rollback to the default
-git checkout conf/config.yaml
+cat > conf/config.yaml <<EOF
+apisix:
+ admin_key:
+ -
+ name: admin
+ key: ADMIN_API_KEY
+ role: admin
+EOF
Review comment:
why repeat those codes so many times?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
