lingsamuel commented on code in PR #1426:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1426#discussion_r1012477213
##########
pkg/providers/gateway/translation/gateway_httproute.go:
##########
@@ -32,6 +32,77 @@ import (
apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
)
+func (t *translator) generatePluginsFromHTTPRouteFilter(filters
[]gatewayv1alpha2.HTTPRouteFilter) apisixv1.Plugins {
+ plugins := apisixv1.Plugins{}
+ for _, filter := range filters {
+ switch filter.Type {
+ case gatewayv1alpha2.HTTPRouteFilterRequestHeaderModifier:
+ t.fillPluginsFromHTTPRequestHeaderFilter(plugins,
filter.RequestHeaderModifier)
+ case gatewayv1alpha2.HTTPRouteFilterRequestRedirect:
+ t.fillPluginsFromHTTPRequestRedirectFilter(plugins,
filter.RequestRedirect)
+ case gatewayv1alpha2.HTTPRouteFilterRequestMirror:
+ // to do
+ }
+ }
+ return plugins
+}
+
+func (t *translator) fillPluginsFromHTTPRequestHeaderFilter(plugins
apisixv1.Plugins, reqHeaderModifier *gatewayv1alpha2.HTTPRequestHeaderFilter) {
Review Comment:
I think `generatePluginsXXXX` is more consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
