biakecw commented on code in PR #8226:
URL: https://github.com/apache/apisix/pull/8226#discussion_r1013745781


##########
apisix/cli/ngx_tpl.lua:
##########
@@ -677,8 +677,8 @@ http {
             if ($http_x_forwarded_for != "") {
                 set $var_x_forwarded_for "${http_x_forwarded_for}, 
${realip_remote_addr}";
             }
-            if ($http_x_forwarded_port != "") {
-                set $var_x_forwarded_port $http_x_forwarded_port;
+            if ($http_x_forwarded_host != "") {
+                set $var_x_forwarded_host $http_x_forwarded_host;

Review Comment:
   My understanding is that this directive is already implemented in 
apisix.http_access_phase() and is redundant here. Is my understanding correct?  
If not,   I am not sure what you mean " Some extra changes are required. See 
https://github.com/apache/apisix/pull/8200/files";  2 days ago.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to