fatihusta commented on code in PR #8279:
URL: https://github.com/apache/apisix/pull/8279#discussion_r1017648154


##########
t/plugin/syslog.t:
##########
@@ -132,8 +132,36 @@ passed
 [error]
 
 
+=== TEST 5: add plugin metadata

Review Comment:
   I fixed test reordering problem.
   
   Should I add "access request" test?
   And is that enough if is require?
   ```
   === TEST 10: access for log format
   --- request
   GET /hello
   --- response_body
   hello world
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to