biakecw commented on code in PR #8219:
URL: https://github.com/apache/apisix/pull/8219#discussion_r1023718333


##########
apisix/admin/stream_routes.lua:
##########
@@ -142,6 +165,15 @@ function _M.delete(id)
         return 400, {error_msg = "missing stream route id"}
     end
 
+    local status, body = _M.get()

Review Comment:
   I have tried to use synced data from  _M.routes() and  it  needs to 
apisix.stream_init_worker()  before calling .
   I agree with you that it is more efficient to   use synced data from 
_M.routes() , but I  get a lot of errors  while adding  
apisix.stream_init_worker()   in stream  subsystem of nginx.conf  
   So after that I took the etcd implementation  based on this suggestion  
[https://github.com/apache/apisix/pull/8219#issuecomment-1311464368](url). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to