JohnsonCaii commented on issue #8343: URL: https://github.com/apache/apisix/issues/8343#issuecomment-1319570361
The logic is correct only if `enable_compression: false`. Please see my input here. > https://github.com/apache/apisix/blob/master/apisix/plugins/log-rotate.lua#L179 The `.tar.gz` suffix is hardcoded here. > > The code itself didn't check if compression was enabled when cleaning up old files here. https://github.com/apache/apisix/blob/master/apisix/plugins/log-rotate.lua#L254 > > In the very first code of this feature, it's correct. [05fc230#diff-cec78832f4c2b34965a93f89b98b12104e34868088ae2a1380973a94d43c0a8aR125](https://github.com/apache/apisix/commit/05fc2306b5f005799e908273cfe11bd5f830459f#diff-cec78832f4c2b34965a93f89b98b12104e34868088ae2a1380973a94d43c0a8aR125) > > Please have a check on it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
