spacewander commented on code in PR #8006:
URL: https://github.com/apache/apisix/pull/8006#discussion_r1026507185
##########
t/kubernetes/discovery/kubernetes.t:
##########
@@ -286,3 +294,5 @@ GET /compare
Content-type: application/json
--- response_body
true
+--- error_log
+failed to get lua_shared_dict
Review Comment:
We can use `--- http_config` to provide such configuration if we can't
generate them automatically.
##########
t/control/discovery.t:
##########
@@ -77,6 +73,8 @@ GET /t
--- response_body
{}
{"fetch_interval":3,"keepalive":true,"prefix":"upstreams","servers":["http://127.0.0.1:8500","http://127.0.0.1:8600"],"timeout":{"connect":2000,"read":2000,"wait":60},"weight":1}
+--- error_log
+connect consul
Review Comment:
What about adding the comment at the top of this file?
##########
t/kubernetes/discovery/kubernetes.t:
##########
@@ -224,6 +230,8 @@ GET /compare
Content-type: application/json
--- response_body
true
+--- error_log
+not found environment variable
Review Comment:
We can use `--- main_config` to provide dummy env var
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
