kingluo commented on code in PR #8006: URL: https://github.com/apache/apisix/pull/8006#discussion_r1027297114
########## t/kubernetes/discovery/kubernetes.t: ########## @@ -286,3 +294,5 @@ GET /compare Content-type: application/json --- response_body true +--- error_log +failed to get lua_shared_dict Review Comment: This test file is only used to compare if the configuration is set as expected, it does not care about whether the k8s function works or not, and in fact, the configuration is invalid and needs to get other auxiliary settings, but that is done by kubernetes2.t and kubernetes3.t. You have to repeat everything from those test files into this test file to shut up the errors, but it's meaningless because it's not the goal of this test file. So all in all, no need to be sensitive to the error log here, as long as the response is ok. So now I choose to add `--- ignore_error_log` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
