lingsamuel commented on code in PR #1471:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1471#discussion_r1029975960
##########
pkg/types/apisix/v1/plugin_types.go:
##########
@@ -177,3 +191,46 @@ func (p *Headers) DeepCopy() *Headers {
p.DeepCopyInto(out)
return out
}
+
+// +k8s:deepcopy-gen=true
+type Expr struct {
+ StringVal string
+ ArrayVal []Expr
+}
+
+func (e *Expr) MarshalJSON() ([]byte, error) {
+ if e.StringVal != "" {
+ return json.Marshal(e.StringVal)
+ } else {
+ return json.Marshal(e.ArrayVal)
+ }
+}
+
+func (expr *Expr) UnmarshalJSON(buf []byte) error {
Review Comment:
It would be better to have a simple test for this function.
##########
pkg/providers/ingress/translation/annotations/plugins/http_method.go:
##########
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package plugins
+
+import (
+
"github.com/apache/apisix-ingress-controller/pkg/providers/ingress/translation/annotations"
+ apisixv1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+type HttpMethod struct{}
+
+// NewHttpHandler creates a handler to convert annotations about
+// HttpMethod to APISIX cors plugin.
+func NewHttpMethodHandler() PluginAnnotationsHandler {
+ return &HttpMethod{}
+}
+
+func (h HttpMethod) PluginName() string {
+ return "response-rewrite"
+}
+
+func (h HttpMethod) Handle(e annotations.Extractor) (interface{}, error) {
+ var plugin apisixv1.ResponseRewriteConfig
+
+ allowMethods :=
e.GetStringsAnnotation(annotations.AnnotationsHttpAllowMethod)
+ blockMethods :=
e.GetStringsAnnotation(annotations.AnnotationsHttpBlockMethod)
+
+ plugin.StatusCode = 405
+ var methodExpr = []apisixv1.Expr{}
+
+ if len(allowMethods) > 0 {
+ //plugin.LuaRestyExpr = []interface{}{
Review Comment:
I guess these lines should be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
