[GitHub] [apisix] 840963657 commented on a diff in pull request #8374: fix: passive healthy code review.

Wed, 23 Nov 2022 00:52:49 -0800 


840963657 commented on code in PR #8374:
URL: https://github.com/apache/apisix/pull/8374#discussion_r1030167186


##########
apisix/init.lua:
##########
@@ -724,6 +724,7 @@ local function healthcheck_passive(api_ctx)
                                            port or api_ctx.balancer_port,
                                            host,
                                            resp_status)
+                return

Review Comment:
   Loop of the 727 line, the function ends when the loop terminates, so think 
break and return have the same effect
   
![image](https://user-images.githubusercontent.com/25243232/203505029-970e7ea1-f392-4664-a83a-3632350d98d3.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to