imjoey commented on pull request #428: URL: https://github.com/apache/apisix-dashboard/pull/428#issuecomment-684483144
@juzhiyuan @membphis @LiteSun Hi all, Currently, users can choose if to support `websocket` when creating a route at 1st step (@membphis, it's at 1st step for now, and this pr wants to move it to 2nd step) , and at 2nd step to choose an existing upstream or manually input the properties of a brand new upstream. While the problem above is the [Admin API for upstream](https://github.com/apache/apisix/blob/master/doc/admin-api.md#upstream) indicates that the `enable_websocket` is a property of the `Upstream` configuration, not `Route`. So this PR is going to move `enable_websocket` to the right target `Upsteam`. Changes proposed in this PR are: - Add support for setting `enable_websocket` property when creating/updating/viewing a Upstream - Move `enable_websocket` out of the `Route` management steps - Adjust the backend codes to remove the incorrect logical codes for `enable_websocket` handling from `Route` Looking forward to your feedback, thank you all. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
