spacewander commented on code in PR #8403: URL: https://github.com/apache/apisix/pull/8403#discussion_r1035550283
########## apisix/plugin.lua: ########## @@ -849,6 +850,71 @@ check_plugin_metadata = function(item) end +local enable_data_encryption +local function enable_gde() + if enable_data_encryption == nil then + enable_data_encryption = + core.table.try_read_attr(local_conf, "apisix", "data_encryption", "enable") + _M.enable_data_encryption = enable_data_encryption Review Comment: @tzssangglass `enable_data_encryption` would be nil in this case? So `enable_data_encryption == nil` will always get a true result and this function doesn't provide a cache if the user doesn't provide a configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
