spacewander commented on code in PR #8434: URL: https://github.com/apache/apisix/pull/8434#discussion_r1037829428
########## apisix/plugins/prometheus/exporter.lua: ########## @@ -410,7 +411,16 @@ local function shared_dict_status() end +-- for test +local function log_process_type() Review Comment: A hook example: https://github.com/apache/apisix/blob/797bc7dbcce37eb565bb7a5207534455f90dcf82/t/cli/test_main.sh#L624 ########## apisix/plugins/prometheus/exporter.lua: ########## @@ -410,7 +411,16 @@ local function shared_dict_status() end +-- for test +local function log_process_type() Review Comment: We can hook the `_M.collect` to avoid adding logging just for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
