AlinsRan commented on code in PR #1386:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1386#discussion_r1037861366
##########
pkg/providers/apisix/provider_init.go:
##########
@@ -93,13 +96,13 @@ func (p *apisixProvider) Init(ctx context.Context) error {
}
}
case config.ApisixV2:
- retRoutes, err :=
p.common.KubeClient.APISIXClient.ApisixV2().ApisixRoutes(ns).List(ctx, opts)
+ retRoutes, err :=
p.apisixSharedInformerFactory.Apisix().V2().ApisixRoutes().Lister().ApisixRoutes(ns).List(labels.Nothing())
Review Comment:
Ditto.
##########
pkg/providers/apisix/provider_init.go:
##########
@@ -48,23 +48,26 @@ func (p *apisixProvider) Init(ctx context.Context) error {
pluginConfigMapA6 = make(map[string]string)
)
+ p.apisixSharedInformerFactory.Start(ctx.Done())
+ p.apisixSharedInformerFactory.WaitForCacheSync(ctx.Done())
+
namespaces := p.namespaceProvider.WatchingNamespaces()
+
for _, key := range namespaces {
log.Debugf("start to watch namespace: %s", key)
wg.Add(1)
go func(ns string) {
defer wg.Done()
// ApisixRoute
- opts := v1.ListOptions{}
switch p.common.Config.Kubernetes.APIVersion {
case config.ApisixV2beta3:
- retRoutes, err :=
p.common.KubeClient.APISIXClient.ApisixV2beta3().ApisixRoutes(ns).List(ctx,
opts)
+ retRoutes, err :=
p.apisixSharedInformerFactory.Apisix().V2beta3().ApisixRoutes().Lister().ApisixRoutes(ns).List(labels.Nothing())
Review Comment:
```suggestion
retRoutes, err :=
p.apisixSharedInformerFactory.Apisix().V2beta3().ApisixRoutes().Lister().ApisixRoutes(ns).List(labels.Everything())
```
##########
pkg/providers/apisix/provider_init.go:
##########
@@ -171,13 +174,13 @@ func (p *apisixProvider) Init(ctx context.Context) error {
}
case config.ApisixV2:
// ApisixConsumer
- retConsumer, err :=
p.common.KubeClient.APISIXClient.ApisixV2().ApisixConsumers(ns).List(ctx, opts)
+ retConsumer, err :=
p.apisixSharedInformerFactory.Apisix().V2().ApisixConsumers().Lister().ApisixConsumers(ns).List(labels.Nothing())
Review Comment:
Ditto.
##########
pkg/providers/apisix/provider_init.go:
##########
@@ -187,13 +190,13 @@ func (p *apisixProvider) Init(ctx context.Context) error {
}
}
// ApisixTls
- retSSL, err :=
p.common.KubeClient.APISIXClient.ApisixV2().ApisixTlses(ns).List(ctx, opts)
+ retSSL, err :=
p.apisixSharedInformerFactory.Apisix().V2().ApisixTlses().Lister().ApisixTlses(ns).List(labels.Nothing())
Review Comment:
Ditto.
##########
pkg/providers/apisix/provider_init.go:
##########
@@ -138,13 +141,13 @@ func (p *apisixProvider) Init(ctx context.Context) error {
switch p.common.Config.Kubernetes.APIVersion {
case config.ApisixV2beta3:
// ApisixConsumer
- retConsumer, err :=
p.common.KubeClient.APISIXClient.ApisixV2beta3().ApisixConsumers(ns).List(ctx,
opts)
+ retConsumer, err :=
p.apisixSharedInformerFactory.Apisix().V2beta3().ApisixConsumers().Lister().ApisixConsumers(ns).List(labels.Nothing())
Review Comment:
Ditto.
##########
pkg/providers/apisix/provider_init.go:
##########
@@ -154,13 +157,13 @@ func (p *apisixProvider) Init(ctx context.Context) error {
}
}
// ApisixTls
- retSSL, err :=
p.common.KubeClient.APISIXClient.ApisixV2beta3().ApisixTlses(ns).List(ctx, opts)
+ retSSL, err :=
p.apisixSharedInformerFactory.Apisix().V2beta3().ApisixTlses().Lister().ApisixTlses(ns).List(labels.Nothing())
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
