lingsamuel commented on code in PR #1451:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1451#discussion_r1040324481
##########
pkg/types/apisix/v1/types.go:
##########
@@ -81,6 +81,13 @@ const (
DefaultUpstreamTimeout = 60
)
+var IngressSchemeMap map[string]struct{} = map[string]struct{}{
Review Comment:
The name doesn't quite fit because these valid schemes are not just for
Ingress. `ValidSchemes` would be better, but I can approve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
