moonming commented on code in PR #8400:
URL: https://github.com/apache/apisix/pull/8400#discussion_r1049341238


##########
docs/en/latest/plugins/inspect.md:
##########
@@ -0,0 +1,171 @@
+---
+title: inspect
+keywords:
+  - APISIX
+  - Plugin
+  - Inspect
+  - Dynamic Lua Debugging
+description: This document contains information about the Apache APISIX 
inspect Plugin.
+---
+
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+## Description
+
+It's useful to set arbitrary breakpoint in any Lua file to inspect the context 
information,
+e.g. print local variables if some condition satisfied.
+
+In this way, you don't need to modify the source code of your project, and 
just get diagnose information
+on demand, i.e. dynamic logging.
+
+This plugin supports setting breakpoints within both interpretd function and 
jit compiled function.
+The breakpoint could be at any position within the function. The function 
could be global/local/module/ananymous.
+
+## Features
+
+* Set breakpoint at any position
+* Dynamic breakpoint
+* customized breakpoint handler
+* You could define one-shot breakpoint
+* Work for jit compiled function
+* If function reference specified, then performance impact is only bound to 
that function (JIT compiled code will not trigger debug hook, so they would run 
fast even if hook is enabled)
+* If all breakpoints deleted, jit could recover
+
+## Operation Graph
+
+![Operation 
Graph](https://raw.githubusercontent.com/apache/apisix/master/docs/assets/images/plugin/inspect.png)
+
+## API to define hook in hooks file
+
+### require("resty.inspect.dbg").set_hook(file, line, func, filter_func)
+
+The breakpoint is specified by `file` (full qualified or short file name) and 
the `line` number.
+
+The `func` specified the scope (which function or global) of jit cache to 
flush:
+
+* If the breakpoint is related to a module function or
+global function, you should set it that function reference, then only the jit 
cache of that function would
+be flushed, and it would not affect other caches to avoid slowing down other 
parts of the program.
+
+* If the breakpointis related to local function or anonymous function,
+then you have to set it to `nil` (because no way to get function reference), 
which would flush the whole jit cache of Lua vm.
+
+You attach a `filter_func` function of the breakpoint, the function takes the 
`info` as argument and returns
+true of false to determine whether the breakpoint would be removed. You could 
setup one-shot breakpoint
+at ease.
+
+The `info` is a hash table which contains below keys:
+
+* `finfo`: `debug.getinfo(level, "nSlf")`
+* `uv`: upvalues hash table
+* `vals`: local variables hash table
+
+## Attributes
+
+| Name               | Type    | Required | Default | Description              
                                                                      |
+|--------------------|---------|----------|---------|------------------------------------------------------------------------------------------------|
+| delay           | integer | False     | 3 | Time in seconds specifying how 
often to check the hooks file.                                       |
+| hooks_file           | string | False     | 
"/var/run/apisix_inspect_hooks.lua"  | Lua file to define hooks, which could be 
a link file. |
+
+## Enabling the Plugin
+
+Plugin is enabled by default (`conf/config-default.yaml`):
+
+```yaml title="conf/config-default.yaml"
+plugins:
+    - inspect
+
+plugin_attr:
+  inspect:
+    delay: 3
+    hooks_file: "/var/run/apisix_inspect_hooks.lua"
+```
+
+## Example usage
+
+```bash
+# create test route
+curl http://127.0.0.1:9180/apisix/admin/routes/test_limit_req -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+    "methods": ["GET"],
+    "uri": "/get",
+    "plugins": {
+        "limit-req": {
+            "rate": 100,
+            "burst": 0,
+            "rejected_code": 503,
+            "key_type": "var",
+            "key": "remote_addr"
+        }
+    },
+    "upstream": {
+        "type": "roundrobin",
+        "nodes": {
+            "httpbin.org": 1
+        }
+    }
+}'
+
+# create a hooks file to set a test breakpoint
+# Note that the breakpoint is associated with the line number,
+# so if the Lua code changes, you need to adjust the line number in the hooks 
file
+cat <<EOF >/tmp/hooks.lua

Review Comment:
   Do not use the /tmp directory, especially for documentation



##########
conf/config-default.yaml:
##########
@@ -555,6 +556,9 @@ plugin_attr:
       send: 60s
 #  redirect:
 #    https_port: 8443   # the default port for use by HTTP redirects to HTTPS
+  inspect:
+    delay: 3            # in seconds
+    hooks_file: "/var/run/apisix_inspect_hooks.lua"

Review Comment:
   There are security risks.
   This Lua code file must be in the APISIX directory, and users who do not 
have write permissions to the APISIX directory cannot write or modify this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to