tao12345666333 commented on code in PR #1530:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/1530#discussion_r1050724477


##########
pkg/providers/types/types.go:
##########
@@ -55,36 +63,58 @@ type ListerInformer struct {
        PodLister   listerscorev1.PodLister
        PodInformer cache.SharedIndexInformer
 
-       ApisixUpstreamLister   kube.ApisixUpstreamLister
-       ApisixUpstreamInformer cache.SharedIndexInformer
-
        ConfigMapLister   listerscorev1.ConfigMapLister
        ConfigMapInformer cache.SharedIndexInformer
+
+       IngressLister   kube.IngressLister
+       IngressInformer cache.SharedIndexInformer
+
+       ApisixUpstreamInformer      cache.SharedIndexInformer
+       ApisixRouteInformer         cache.SharedIndexInformer
+       ApisixPluginConfigInformer  cache.SharedIndexInformer
+       ApisixConsumerInformer      cache.SharedIndexInformer
+       ApisixTlsInformer           cache.SharedIndexInformer
+       ApisixClusterConfigInformer cache.SharedIndexInformer
+
+       ApisixRouteLister         kube.ApisixRouteLister
+       ApisixUpstreamLister      kube.ApisixUpstreamLister
+       ApisixPluginConfigLister  kube.ApisixPluginConfigLister
+       ApisixConsumerLister      kube.ApisixConsumerLister
+       ApisixTlsLister           kube.ApisixTlsLister
+       ApisixClusterConfigLister kube.ApisixClusterConfigLister
 }
 
-func (c *ListerInformer) Run(ctx context.Context) {
+func (c *ListerInformer) StartAndWaitSync(ctx context.Context) bool {

Review Comment:
   ```suggestion
   func (c *ListerInformer) StartAndWaitForCacheSync(ctx context.Context) bool {
   ```
   
   Can we rename it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to