spacewander commented on code in PR #8556:
URL: https://github.com/apache/apisix/pull/8556#discussion_r1056083453
##########
apisix/plugins/request-id.lua:
##########
@@ -129,6 +129,7 @@ local function gen_data_machine(max_number)
if err4 then
snowflake_inited = nil
data_machine = nil
+ timers.unregister_timer("plugin#request-id")
Review Comment:
Could we add a test to ensure the number of `unregister_timer` call is
correct? For instance, via injecting some code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
