spacewander commented on code in PR #8558:
URL: https://github.com/apache/apisix/pull/8558#discussion_r1057088289
##########
t/plugin/limit-count-redis-cluster.t:
##########
@@ -384,3 +384,170 @@ GET /hello
hello world
--- error_log
connection refused
+
+
+
+=== TEST 12: set route, use error type for redis_cluster_ssl and
redis_cluster_ssl_verify
+--- config
+ location /t {
+ content_by_lua_block {
+ local t = require("lib.test_admin").test
+ local code, body = t('/apisix/admin/routes/1',
+ ngx.HTTP_PUT,
+ [[{
+ "plugins": {
+ "limit-count": {
+ "count": 2,
+ "time_window": 60,
+ "rejected_code": 503,
+ "key": "remote_addr",
+ "policy": "redis-cluster"
+ "redis_timeout": 1001,
+ "redis_cluster_nodes": [
+ "127.0.0.1:7000",
+ "127.0.0.1:7001"
+ ],
+ "redis_cluster_name": "redis-cluster-1",
+ "redis_cluster_ssl": "true",
+ "redis_cluster_ssl_verify": "false"
+ }
+ },
+ "upstream": {
+ "nodes": {
+ "127.0.0.1:1980": 1
+ },
+ "type": "roundrobin"
+ },
+ "uri": "/hello"
+ }]]
+ )
+
+ if code >= 300 then
+ ngx.status = code
+ end
+ ngx.print(body)
+ }
+ }
+--- error_code: 400
+--- error_log
+Expected comma or object end but found T_STRING
Review Comment:
The check schema err isn't like this. Please check if the provided data is
valid JSON.
##########
ci/pod/docker-compose.plugin.yml:
##########
@@ -262,6 +262,72 @@ services:
CONTEXT_MODE: "self-host"
FUNC_CONTEXT:
"{\"name\":\"HelloWorld\",\"version\":\"v1.0.0\",\"port\":\"8080\",\"runtime\":\"Knative\"}"
+ ## RedisCluster Enable TLS
+ redis-node-0:
+ image: docker.io/bitnami/redis-cluster:7.0
+ volumes:
+ - ./t/certs:/certs
+ environment:
+ - 'ALLOW_EMPTY_PASSWORD=yes'
+ - 'REDIS_NODES=redis-node-0 redis-node-1 redis-node-2 redis-node-3
redis-node-4 redis-node-5'
+ - 'REDIS_TLS_ENABLED=yes'
+ - 'REDIS_TLS_CERT_FILE=/certs/mtls_server.crt'
+ - 'REDIS_TLS_KEY_FILE=/certs/mtls_server.key'
+ - 'REDIS_TLS_CA_FILE=/certs/mtls_ca.crt'
+ - 'REDIS_TLS_AUTH_CLIENTS=no'
+ ports:
+ - '7000:6379'
+
+ ## RedisCluster Enable TLS
+ redis-node-0:
Review Comment:
There are two redis-node-0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
