tao12345666333 commented on code in PR #1553:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1553#discussion_r1059281950
##########
pkg/providers/apisix/translation/apisix_upstream.go:
##########
@@ -141,6 +141,7 @@ func (t *translator)
translateExternalApisixUpstream(namespace, upstream string)
if err != nil {
return nil, err
}
+ ups.Metadata.Labels = au.ObjectMeta.Labels
Review Comment:
I don't think this is appropriate, it will overwrite all labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
