liuxiran commented on a change in pull request #432:
URL: https://github.com/apache/apisix-dashboard/pull/432#discussion_r484138840
##########
File path: api/route/route.go
##########
@@ -209,6 +223,15 @@ func updateRoute(c *gin.Context) {
}
}()
logger.Info(rd)
+ if isCreateGroup {
+ if err :=
tx.Model(&service.RouteGroupDao{}).Create(routeGroup).Error; err != nil {
+ tx.Rollback()
Review comment:
Refer to the original design, route must be in a group, if the group has
not exited, create with the route. so here if the group create with error, do
rollback :) @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
