Gallardot commented on PR #1523: URL: https://github.com/apache/apisix-ingress-controller/pull/1523#issuecomment-1369694646
I think this PR is ready for review. But there are some field naming issues that I think need to be discussed together. 1. Is the new `instance-id` configuration appropriate? The `ingress_class` configuration is not reused mainly to avoid version incompatibility. Reduce the cost of enabling this feature from inventory projects and reduce the hassle of version upgrades. 2. New `IngressClass` field in ApisixRoute object. Is this name appropriate? How about `gatewayclass`? @tao12345666333 @AlinsRan @lingsamuel @tokers WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
