anhldbk commented on code in PR #1593: URL: https://github.com/apache/apisix-ingress-controller/pull/1593#discussion_r1065853837
########## docs/en/latest/deployments/ack.md: ########## @@ -44,14 +44,15 @@ The script below installs APISIX and the ingress controller: helm repo add apisix https://charts.apiseven.com helm repo add bitnami https://charts.bitnami.com/bitnami helm repo update -kubectl create ns ingress-apisix helm install apisix apisix/apisix \ --set gateway.type=LoadBalancer \ --set ingress-controller.enabled=true \ --set etcd.persistence.storageClass="alicloud-disk-ssd" \ --set etcd.persistence.size="20Gi" \ + --create-namespace \ --namespace ingress-apisix \ - --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix + --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix \ + --set ingress-controller.config.apisix.adminAPIVersion=v3 kubectl get service --namespace ingress-apisix Review Comment: @tokers Should it look like this? ```bash # We use Apisix 3.0 as the example. If you're using Apisix v2.x, please set to v2 ADMIN_API_VERSION=v3 helm install apisix apisix/apisix \ --set gateway.type=LoadBalancer \ --set ingress-controller.enabled=true \ --set etcd.persistence.storageClass="alicloud-disk-ssd" \ --set etcd.persistence.size="20Gi" \ --create-namespace \ --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix \ --set ingress-controller.config.apisix.adminAPIVersion=$ADMIN_API_VERSION ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
