tokers commented on code in PR #401:
URL: https://github.com/apache/apisix-helm-chart/pull/401#discussion_r1066498687


##########
charts/apisix/templates/_pod.tpl:
##########
@@ -62,7 +62,11 @@ spec:
         {{- if (gt (len .tcp) 0) }}
         {{- range $index, $port := .tcp }}
         - name: proxy-tcp-{{ $index | toString }}
+        {{- if kindIs "map" $port }}
+          containerPort: {{ $port.addr }}

Review Comment:
   `addr` might contains IP, so here we cannot treat it as a port, we may need 
to use `splitList` to fetch the port from the `addr`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to