[GitHub] [apisix-dashboard] incubator4 commented on pull request #2704: fix plugins display in list of routes

[GitBox]

incubator4 commented on PR #2704:
URL: 
https://github.com/apache/apisix-dashboard/pull/2704#issuecomment-1382849666

   > Hi, could you add some comparison pictures to facilitate community 
members' review PR? (Because we don't have an online preview yet 😢)
   
   My apologize for not replying soon. This following might show difference 
between fix bugs and before.
   
   ### Tags
   
   cause of tags don't have attribute width, it might not be displayed 
correctly when the screen width is too short
   
   #### Before
   
   <img width="572" alt="image" 
src="https://user-images.githubusercontent.com/26524777/212483623-8955ef86-6c16-4221-a942-2a9fd478cab2.png";>
   
   #### After
   
   <img width="572" alt="image" 
src="https://user-images.githubusercontent.com/26524777/212483831-b0f0d86c-7dbc-4577-8bbd-0ddb625e2232.png";>
   
   
   ### Tags
   
   due to plugins have neither width nor override render function. 
   
   #### Before
   
   <img width="572" alt="image" 
src="https://user-images.githubusercontent.com/26524777/212484036-658782de-e8ca-4c63-bb59-6ec532c4e2af.png";>
   
   
   #### After
   
   <img width="572" alt="image" 
src="https://user-images.githubusercontent.com/26524777/212484053-8044c838-d472-452d-bbc9-0f2d8d2fd04f.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org