LiteSun commented on a change in pull request #456:
URL: https://github.com/apache/apisix-dashboard/pull/456#discussion_r485291538
##########
File path: src/pages/Route/components/CreateStep4/CreateStep4.tsx
##########
@@ -44,7 +46,12 @@ const CreateStep4: React.FC<Props> = ({ form1, form2,
redirect, ...rest }) => {
<h2 style={style}>{formatMessage({ id:
'route.create.define.api.backend.server' })}</h2>
<Step2 {...rest} form={form2} disabled />
<h2 style={style}>{formatMessage({ id:
'route.create.plugin.configuration' })}</h2>
- <PluginPage data={rest.data.step3Data.plugins} disabled />
+ {Boolean(Object.keys(plugins).length !== 0) && (
+ <PluginPage data={rest.data.step3Data.plugins} disabled />
+ )}
+ {Boolean(Object.keys(script).length !== 0) && (
+ <PluginChart data={rest.data.step3Data.script.chart} readonly
onChange={() => {}} />
Review comment:
it seems PluginOrchestration is a better choice, I will
change`PluginChart` to `PluginOrchestration` later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
