spacewander commented on issue #8811: URL: https://github.com/apache/apisix/issues/8811#issuecomment-1423455170
> > It seems the add_header added in the same PR which causes this issue also has the same problem: > > https://github.com/apache/apisix/blob/a18573a3b8775f5a92ba92b948e8212affbf7057/apisix/core/request.lua#L146 > > > > It doesn't update the cache in ctx too. > > @jiangfucheng Maybe we can fix it at the same time. > > In my opinion, i need to do two things: 1.Fix calls of "proxy-rewirte" plugin that from`set_header( header_name, header_value)` to `set_header( ctx, header_name, header_value)` to avoid warn log. 2.Refactor `add_header(header_name, header_value)` method to `add_header(ctx, header_name, header_value)`, this method need add logic to invalidate ctx.headers cache. Is right? Correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
