spacewander commented on code in PR #8821:
URL: https://github.com/apache/apisix/pull/8821#discussion_r1102191768
##########
t/plugin/error-log-logger-kafka.t:
##########
@@ -87,7 +87,8 @@ done
"host": "127.0.0.1",
"port": 9092
}],
- "kafka_topic": "test2"
+ "kafka_topic": "test2",
+ "meta_refresh_interval": 1
Review Comment:
Can we add a mock test to ensure this config is passed to broker_config?
##########
docs/en/latest/plugins/error-log-logger.md:
##########
@@ -60,6 +60,7 @@ It might take some time to receive the log data. It will be
automatically sent a
| kafka.required_acks | integer | False | 1
| [0, 1, -1] | Number of acknowledgements the leader needs to
receive for the producer to consider the request complete. This controls the
durability of the sent records. The attribute follows the same configuration as
the Kafka `acks` attribute. See [Apache Kafka
documentation](https://kafka.apache.org/documentation/#producerconfigs_acks)
for more. |
| kafka.key | string | False |
| | Key used for allocating partitions for messages.
|
| kafka.cluster_name | integer | False | 1 | [0,...]
| Name of the cluster. Used when there are two or more Kafka
clusters. Only works if the `producer_type` attribute is set to `async`.
|
+| kafka.meta_refresh_interval | integer | optional | 30 |
[1,...] | `refresh_interval` parameter in
[lua-resty-kafka](https://github.com/doujiang24/lua-resty-kafka) specifies the
time to auto refresh the metadata, in seconds.|
Review Comment:
```suggestion
| kafka.meta_refresh_interval | integer | False | 30 |
[1,...] | `refresh_interval` parameter in
[lua-resty-kafka](https://github.com/doujiang24/lua-resty-kafka) specifies the
time to auto refresh the metadata, in seconds.|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
