spacewander commented on code in PR #8823:
URL: https://github.com/apache/apisix/pull/8823#discussion_r1103942843
##########
docs/en/latest/plugins/opentelemetry.md:
##########
@@ -58,7 +58,7 @@ You can set up the collector by configuring it in you
configuration file (`conf/
| trace_id_source | enum | random
| Source of the trace ID. Valid values are `random`
or `x-request-id`. When set to `x-request-id`, the value of the `x-request-id`
header will be used as trace ID. Make sure that is matches the regex pattern
`[0-9a-f]{32}`. |
| resource | object |
| Additional
[resource](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/resource/sdk.md)
appended to the trace.
|
| collector | object | {address =
"127.0.0.1:4318", request_timeout = 3} | OpenTelemetry Collector configuration.
|
-| collector.address | string | 127.0.0.1:4318
| Collector address.
|
+| collector.address | string | 127.0.0.1:4318
| Collector address. If the collector serve on
https, use https://127.0.0.1:4318 as address.
|
Review Comment:
```suggestion
| collector.address | string | 127.0.0.1:4318
| Collector address. If the collector serves on
https, use https://127.0.0.1:4318 as the address.
|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
