jiangfucheng commented on code in PR #8809: URL: https://github.com/apache/apisix/pull/8809#discussion_r1104517183
########## t/cli/test_deployment_control_plane.sh: ########## @@ -40,6 +40,37 @@ fi echo "passed: should check deployment schema during init" +# The 'admin.apisix.dev' is injected by ci/common.sh@set_coredns +echo ' +apisix: + enable_admin: false +deployment: + role: control_plane + role_control_plane: + config_provider: etcd + conf_server: + listen: admin.apisix.dev:12345 + cert: t/certs/mtls_server.crt + cert_key: t/certs/mtls_server.key + admin: + admin_listen: + port: "abcd" + etcd: + prefix: "/apisix" + host: + - http://127.0.0.1:2379 + certs: + trusted_ca_cert: t/certs/mtls_ca.crt +' > conf/config.yaml + +out=$(make init 2>&1 || true) +if ! echo "$out" | grep 'expect: number, but got: string'; then Review Comment: I changed a special field, it can be merged, but can't pass config validation, although this way is not perfect。🤣 ########## apisix/cli/schema.lua: ########## @@ -409,7 +410,7 @@ local deployment_schema = { default = {}, }, }, - required = {"etcd", "role_control_plane"} + required = {"etcd", "admin", "role_control_plane"} Review Comment: Removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
