tao12345666333 commented on PR #1523: URL: https://github.com/apache/apisix-ingress-controller/pull/1523#issuecomment-1429344801
Sorry for the delay. I think using `IngressClass` is enough. [1] In the resources of the Gateway API specification, there is `GatewayClass`, which allows for the definition of a controller name[2] to distinguish between different controllers. So - Using `controller-name` instead of `instance-id`. It already exists, make it configurable. https://github.com/apache/apisix-ingress-controller/blob/4241b673b3fd385e82d5ca3a39fed8acafa5bd64/pkg/config/config.go#L59-L61 - The `ingressClass` field is a good fit. We can reuse the IngressClass resource directly, and it is easier to integrate with existing tools or users' existing configuration. No other resources need to be introduced. 1: https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-class 2: https://gateway-api.sigs.k8s.io/api-types/gatewayclass/#gatewayclass-controller-selection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
