Qiuqiu0505 opened a new pull request, #8869:
URL: https://github.com/apache/apisix/pull/8869

   ### Description
   allow_origins: Origins to allow CORS
   allow_origins_by_regex: Regex to match with origin for enabling CORS.
   
   As a user,  When I set the value of allow_origins_by_regex,the orgins to 
allow CORS must be in the range and other origin will  be failed. But it's not 
ready. 
   In code,the default value of allow orgins  is  ‘*’ and all origins will be 
passed and allow_origins_by_regex has not effect.
   
   In my opinion,allow_origins_by_regex should be considered first.  If the 
allow_origins_by_regex has no value. it can judge using allow_origins. 
   Therefore, I submit the changes. Thanks.
   
   
   Fixes # (issue)
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to