shreemaan-abhishek commented on code in PR #8866:
URL: https://github.com/apache/apisix/pull/8866#discussion_r1112810367
##########
apisix/secret/vault.lua:
##########
@@ -53,10 +54,15 @@ local function make_request_to_vault(conf, method, key,
data)
local req_addr = conf.uri .. norm_path("/v1/"
.. conf.prefix .. "/" .. key)
+ local token, _ = env.fetch_by_uri(conf.token)
Review Comment:
I think it's okay to import using `require` and use because if in the future
we need to use the env module again in this file then we won't have to
re-import using `require`.
Also, at that time in the future, we will not have to replace
`core.env.fetch_by_uri` with `env.fetch_by_uri`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
