spacewander commented on code in PR #8898: URL: https://github.com/apache/apisix/pull/8898#discussion_r1113785034
########## t/cli/test_main.sh: ########## @@ -211,6 +211,32 @@ fi echo "passed: resolve variables" +# support reserved environment variable APISIX_DEPLOYMENT_ETCD_HOST + +echo ' +deployment: + role: traditional + role_traditional: + config_provider: etcd + etcd: + host: + - "http://127.0.0.1:2379"; +' > conf/config.yaml + +out=$(APISIX_DEPLOYMENT_ETCD_HOST='["http://127.0.0.1:2333";]' make init 2>&1 || true) +if ! echo "$out" | grep "connection refused" > /dev/null; then + echo "failed: failed to configure etcd host with reserved environment variable" + exit 1 +fi + +out=$(APISIX_DEPLOYMENT_ETCD_HOST='["http://127.0.0.1:2333";]' make run 2>&1 || true) Review Comment: Can you configure a connectable address and check if it works? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
