tao12345666333 commented on code in PR #1666:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1121099401
##########
Makefile:
##########
@@ -222,9 +222,19 @@ verify-license:
verify-mdlint:
docker run -it --rm -v $(PWD):/work tmknom/markdownlint '**/*.md'
--ignore node_modules --ignore CHANGELOG.md
+### verify-yamllint: Verify yaml files lint rules for `samples/deploy`
directory.
+.PHONY: verify-yamllint
+verify-yamllint:
+ docker run -it --rm -v $(PWD):/yaml peterdavehello/yamllint yamllint
samples/deploy
+
### verify-all: Verify all verify- rules.
.PHONY: verify-all
-verify-all: verify-codegen verify-license verify-mdlint
+verify-all: verify-codegen verify-license verify-mdlint verify-yamllint
+
+### update-yamlfmt: Update yaml files format for `samples/deploy`
directory.
+.PHONY: update-yamlfmt
+update-yamlfmt:
+ go install github.com/google/yamlfmt/cmd/yamlfmt@latest && yamlfmt
samples/deploy
Review Comment:
The `peterdavehello/yamllint ` image is Dockerized
https://github.com/adrienverge/yamllint
But in the `update-yamlfmt` job you install
https://github.com/google/yamlfmt, why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
