tao12345666333 commented on code in PR #593:
URL:
https://github.com/apache/apisix-ingress-controller/pull/593#discussion_r1130538263
##########
pkg/providers/apisix/apisix_route.go:
##########
@@ -534,6 +534,23 @@ func (c *apisixRouteController) handleSyncErr(obj
interface{}, errOrigin error)
c.MetricsCollector.IncrSyncOperation("route", "failure")
}
+func (c *apisixRouteController) isEffective(ar kube.ApisixRoute) bool {
+ var icn string
+
+ switch ar.GroupVersion() {
+ case config.ApisixV2beta3:
+ icn = ar.V2beta3().Spec.IngressClassName
Review Comment:
ditto
##########
pkg/kube/apisix/apis/config/v2beta3/types.go:
##########
@@ -44,8 +44,9 @@ type ApisixStatus struct {
// ApisixRouteSpec is the spec definition for ApisixRouteSpec.
type ApisixRouteSpec struct {
- HTTP []ApisixRouteHTTP `json:"http,omitempty" yaml:"http,omitempty"`
- Stream []ApisixRouteStream `json:"stream,omitempty"
yaml:"stream,omitempty"`
+ IngressClassName string `json:"ingressClassName,omitempty"
yaml:"ingressClassName,omitempty"`
+ HTTP []ApisixRouteHTTP `json:"http,omitempty"
yaml:"http,omitempty"`
+ Stream []ApisixRouteStream `json:"stream,omitempty"
yaml:"stream,omitempty"`
Review Comment:
We don't need to change the v2beta3 resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
