ps-19 commented on code in PR #1721:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1721#discussion_r1132113912
##########
Makefile:
##########
@@ -18,12 +18,12 @@ default: help
VERSION ?= 1.6.0
-# 2.15 image: "2.15.0-alpine"
-TARGET_APISIX_VERSION ?= "3.1.0-centos"
+
+TARGET_APISIX_VERSION ?= "dev"
APISIX_ADMIN_API_VERSION ?= "v3"
ifneq ($(APISIX_ADMIN_API_VERSION), "v3")
-ifeq ($(TARGET_APISIX_VERSION), "3.1.0-centos")
- TARGET_APISIX_VERSION = "2.15.0-alpine"
+ifeq ($(TARGET_APISIX_VERSION), "dev")
+ TARGET_APISIX_VERSION = "3.1.0-centos"
Review Comment:
TARGET_APISIX_VERSION ?= "dev"
APISIX_ADMIN_API_VERSION ?= "v3"
ifeq ($(APISIX_ADMIN_API_VERSION), "v3")
ifeq ($(TARGET_APISIX_VERSION), "dev")
TARGET_APISIX_VERSION = "3.1.0-centos"
endif
else ifeq ($(APISIX_ADMIN_API_VERSION), "v2")
ifeq ($(TARGET_APISIX_VERSION), "dev")
TARGET_APISIX_VERSION = "2.12-centos"
endif
else
ifeq ($(TARGET_APISIX_VERSION), "dev")
TARGET_APISIX_VERSION = "2.12-centos"
endif
endif
What should be in the condition like ifeq ($(APISIX_ADMIN_API_VERSION),
"v3") is true and ifeq ($(TARGET_APISIX_VERSION), "dev")
then I should:
TARGET_APISIX_VERSION = "3.1.0-centos"
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
