spacewander commented on code in PR #8681:
URL: https://github.com/apache/apisix/pull/8681#discussion_r1133408463
##########
apisix/cli/ops.lua:
##########
@@ -825,7 +825,10 @@ local function start(env, ...)
init_etcd(env, args)
end
- util.execute_cmd(env.openresty_args)
+ local data, err = util.execute_cmd(env.openresty_args)
+ if not err and data and data ~= "" then
+ print(data)
Review Comment:
It is useless to print the access log only after the Nginx exited.
##########
t/cli/plugin/test_file_logger_std_output.sh:
##########
@@ -0,0 +1,82 @@
+#!/usr/bin/env bash
+
Review Comment:
Could we remove the intermediate directory, so this file can be tested
without modifying the ci script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
