dotSlashLu opened a new pull request #2222:
URL: https://github.com/apache/apisix/pull/2222


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   
https://github.com/apache/apisix/blob/98da870976a4893a87b31300276c8c548dac14c0/apisix/utils/batch-processor.lua#L59
 needs `ok` and `err`, but `func` in `kafka-logger` returns nil if it's ok. 
This behaviour causes a lot of unnecessary logs though it's actually ok:
   
   ```
   2020/09/14 07:29:38 [error] 67351#0: *180881201 [lua] 
batch-processor.lua:61: Batch Processor[kafka logger] failed to process 
entries: nil, context: ngx.timer, client: 10.100.2.45, server: 0.0.0.0:443
   2020/09/14 07:29:38 [error] 67351#0: *180881201 [lua] 
batch-processor.lua:68: Batch Processor[kafka logger] exceeded the 
max_retry_count[1] dropping the entries, context: ngx.timer, client: 
10.100.2.45, server: 0.0.0.0:443
   ```
   
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features 
have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to