monkeyDluffy6017 commented on code in PR #9210:
URL: https://github.com/apache/apisix/pull/9210#discussion_r1156783152
##########
apisix/plugins/log-rotate.lua:
##########
@@ -85,7 +85,7 @@ local function get_last_index(str, key)
return n
end
-
+-- get the log directory path
Review Comment:
The functions needs to be separated by two blank lines
##########
apisix/plugins/log-rotate.lua:
##########
@@ -122,7 +122,7 @@ local function tab_sort_comp(a, b)
return a > b
end
-
+-- scans the log directory and returns a sorted table of matching log files
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
