kingluo commented on PR #9259: URL: https://github.com/apache/apisix/pull/9259#issuecomment-1500059762
> @kingluo I've implemented the lua API to export raxRemove. And compile the codes into dynamic shared library. To filter non route keys in sync_data() method, I've already filtered them such as "/apisix/upstreams". the codes is in config_etcd.lua line 484 > > To update one route, if the path of new and old route is the same, find the route in routes array by route id, and assign the new route data to the correct element of the routes array. Then delete routes with old path, insert new routes with new path. To make a good code practice, please apply the refactoring in the suitable scope, i.e. filter. Anyways, please submit a full but minimum code change upon the master branch instead, remove irrelevant changes, and provide test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
