tao12345666333 commented on code in PR #1460:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1460#discussion_r1162444917
##########
Makefile:
##########
@@ -325,3 +324,19 @@ install-gateway-api-local:
.PHONY: uninstall-gateway-api
uninstall-gateway-api:
kubectl delete -f $(GATEWAY_API_CRDS_LOCAL_PATH)
+
+### dev-env: Launch development environment
+.PHONY: dev-env
+dev-env: kind-up pack-image
+ helm repo add apisix https://charts.apiseven.com
+ helm repo update
+ helm install apisix apisix/apisix \
+ --set gateway.type=NodePort \
+ --set ingress-controller.enabled=true \
+ --namespace ingress-apisix \
+ --create-namespace
+ kubectl set image deployment/apisix-ingress-controller
ingress-controller=$(REGISTRY)/apache/apisix-ingress-controller:dev --namespace
ingress-apisix
+
Review Comment:
We don't need to do any additional processing for 'helm repo add'. Even if
the repository already exists, it won't affect normal logic.
```
➜ ~ helm repo add apisix https://charts.apiseven.com
"apisix" already exists with the same configuration, skipping
➜ ~ echo $?
0
```
But the judgment logic of `helm list` is very good, unless we use ` helm
upgrade` directly. Using `helm list` to pre-judge can be safer, and I agree.
@zou8944 PTAL, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
